Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE]: accessibility docs for SWC05 #4757

Closed
wants to merge 35 commits into from

Conversation

nikkimk
Copy link
Contributor

@nikkimk nikkimk commented Sep 16, 2024


!!! NOTE TO REVIEWERS !!!

Please only review the docs listed in How has this been tested? section.

When this PR is reviewed, it will be merged into #4756, where all of the changes will be reviewed before merging into main.

Please place any other feedback in #4756


Description

Improving the accessibility documentation of components.

Related issue(s)

Motivation and context

Documentation should provide more information and examples that demonstrate how to use the components accessibly.

How has this been tested?

<sp-icon>

Review icon docs

  • Are the examples accessible?
  • Do the docs examples and text provide information on how to use the component accessibly?
  • If the component is to be used in the context of another component, do the examples include how that component is used accessibly in that context?
  • Are the docs headings logical and consistent across these components? (1)

<sp-icons>

Review icons docs

  • Are the examples accessible?
  • Do the docs examples and text provide information on how to use the component accessibly?
  • If the component is to be used in the context of another component, do the examples include how that component is used accessibly in that context?
  • Are the docs headings logical and consistent across these components? (1)

<sp-iconset>

Review iconset docs

  • Are the examples accessible?
  • Do the docs examples and text provide information on how to use the component accessibly?
  • If the component is to be used in the context of another component, do the examples include how that component is used accessibly in that context?
  • Are the docs headings logical and consistent across these components? (1)

<sp-icons-ui>

Review icons-ui docs

  • Are the examples accessible?
  • Do the docs examples and text provide information on how to use the component accessibly?
  • If the component is to be used in the context of another component, do the examples include how that component is used accessibly in that context?
  • Are the docs headings logical and consistent across these components? (1)

<sp-icons-workflow>

Review icons-workflow docs

  • Are the examples accessible?
  • Do the docs examples and text provide information on how to use the component accessibly?
  • If the component is to be used in the context of another component, do the examples include how that component is used accessibly in that context?
  • Are the docs headings logical and consistent across these components? (1)

Developing a Component Guide

1. You can use the WAVE browser extension's Structure tab to review heading structure.

Font sizes

  • Are the above component document font sizes consistent with the following design recommendations?
    • h1: heading XXL, serif, heavy
    • h2: heading L, sans-serif
    • h3: heading M, sans-serif
    • h4: heading S, sans-serif
    • h5: detail L
    • body: body M, sans-serif

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. N/A
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@nikkimk nikkimk requested review from najikahalsema and removed request for najikahalsema September 16, 2024 21:02
@nikkimk nikkimk marked this pull request as ready for review September 16, 2024 21:04
@nikkimk nikkimk requested a review from a team as a code owner September 16, 2024 21:04
Copy link

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Copy link

github-actions bot commented Sep 16, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 228.306 kB 217.229 kB 🏆 217.593 kB
Scripts 57.897 kB 52.597 kB 🏆 52.843 kB
Stylesheet 34.535 kB 30.153 kB 🏆 30.246 kB
Document 6.222 kB 5.464 kB 🏆 5.503 kB
Font 126.82 kB 126.605 kB 🏆 126.651 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@coveralls
Copy link
Collaborator

coveralls commented Sep 16, 2024

Pull Request Test Coverage Report for Build 11462493768

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 98.227%

Totals Coverage Status
Change from base Build 11386937763: -0.002%
Covered Lines: 32983
Relevant Lines: 33395

💛 - Coveralls

Copy link

github-actions bot commented Sep 16, 2024

Tachometer results

Chrome

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 83.01ms - 84.56ms - faster ✔
7% - 11%
6.17ms - 9.85ms
branch 407 kB 90.13ms - 93.47ms slower ❌
7% - 12%
6.17ms - 9.85ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 500 kB 53.84ms - 55.20ms - faster ✔
3% - 7%
1.86ms - 4.35ms
branch 476 kB 56.59ms - 58.67ms slower ❌
3% - 8%
1.86ms - 4.35ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 561 kB 73.05ms - 74.46ms - faster ✔
3% - 6%
2.21ms - 4.55ms
branch 518 kB 76.20ms - 78.07ms slower ❌
3% - 6%
2.21ms - 4.55ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 583 kB 49.38ms - 50.68ms - faster ✔
3% - 6%
1.36ms - 3.13ms
branch 541 kB 51.67ms - 52.88ms slower ❌
3% - 6%
1.36ms - 3.13ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 701 kB 143.78ms - 147.66ms - faster ✔
5% - 8%
7.51ms - 12.78ms
branch 659 kB 154.09ms - 157.66ms slower ❌
5% - 9%
7.51ms - 12.78ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 658 kB 69.45ms - 70.89ms - faster ✔
6% - 9%
4.85ms - 7.13ms
branch 616 kB 75.28ms - 77.05ms slower ❌
7% - 10%
4.85ms - 7.13ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 67.37ms - 72.12ms - faster ✔
3% - 10%
2.03ms - 7.28ms
branch 615 kB 73.29ms - 75.52ms slower ❌
3% - 11%
2.03ms - 7.28ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 847 kB 1873.24ms - 1876.56ms - unsure 🔍
-0% - +0%
-4.29ms - +0.18ms
branch 802 kB 1875.46ms - 1878.46ms unsure 🔍
-0% - +0%
-0.18ms - +4.29ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 845 kB 1878.04ms - 1881.34ms - unsure 🔍
-0% - +0%
-2.68ms - +1.62ms
branch 801 kB 1878.84ms - 1881.60ms unsure 🔍
-0% - +0%
-1.62ms - +2.68ms
-

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 438 kB 12.08ms - 12.32ms - faster ✔
3% - 6%
0.41ms - 0.80ms
branch 415 kB 12.65ms - 12.96ms slower ❌
3% - 7%
0.41ms - 0.80ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 497 kB 112.60ms - 113.79ms - faster ✔
1% - 3%
1.49ms - 3.19ms
branch 455 kB 114.92ms - 116.14ms slower ❌
1% - 3%
1.49ms - 3.19ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 718 kB 529.57ms - 536.02ms - unsure 🔍
-1% - +0%
-6.08ms - +1.92ms
branch 676 kB 532.51ms - 537.25ms unsure 🔍
-0% - +1%
-1.92ms - +6.08ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 489 kB 46.50ms - 48.15ms - faster ✔
2% - 6%
0.76ms - 2.76ms
branch 446 kB 48.52ms - 49.64ms slower ❌
2% - 6%
0.76ms - 2.76ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 495 kB 51.43ms - 52.65ms - faster ✔
2% - 5%
1.27ms - 2.86ms
branch 452 kB 53.59ms - 54.61ms slower ❌
2% - 6%
1.27ms - 2.86ms
-

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 516 kB 39.29ms - 40.06ms - faster ✔
2% - 4%
0.79ms - 1.81ms
branch 492 kB 40.64ms - 41.32ms slower ❌
2% - 5%
0.79ms - 1.81ms
-

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 429 kB 41.30ms - 42.10ms - faster ✔
2% - 5%
1.06ms - 2.18ms
branch 405 kB 42.93ms - 43.70ms slower ❌
3% - 5%
1.06ms - 2.18ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 678 kB 97.72ms - 99.44ms - faster ✔
3% - 5%
2.80ms - 5.52ms
branch 633 kB 101.68ms - 103.80ms slower ❌
3% - 6%
2.80ms - 5.52ms
-

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 501 kB 43.61ms - 44.94ms - faster ✔
1% - 5%
0.63ms - 2.48ms
branch 478 kB 45.18ms - 46.48ms slower ❌
1% - 6%
0.63ms - 2.48ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 38.80ms - 39.30ms - faster ✔
2% - 4%
0.74ms - 1.55ms
branch 718 kB 39.88ms - 40.51ms slower ❌
2% - 4%
0.74ms - 1.55ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 424.28ms - 430.32ms - faster ✔
2% - 4%
7.73ms - 17.23ms
branch 718 kB 436.11ms - 443.45ms slower ❌
2% - 4%
7.73ms - 17.23ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 51.49ms - 52.79ms - faster ✔
6% - 9%
3.15ms - 5.02ms
branch 644 kB 55.56ms - 56.89ms slower ❌
6% - 10%
3.15ms - 5.02ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 554 kB 81.64ms - 82.77ms - unsure 🔍
-2% - -0%
-1.47ms - +0.00ms
branch 511 kB 82.47ms - 83.41ms unsure 🔍
-0% - +2%
-0.00ms - +1.47ms
-

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 435 kB 45.34ms - 46.15ms - faster ✔
3% - 8%
1.57ms - 3.69ms
branch 411 kB 47.40ms - 49.35ms slower ❌
3% - 8%
1.57ms - 3.69ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 404 kB 20.86ms - 21.99ms - faster ✔
1% - 8%
0.12ms - 1.88ms
branch 381 kB 21.75ms - 23.10ms slower ❌
0% - 9%
0.12ms - 1.88ms
-

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 400 kB 10.41ms - 10.55ms - faster ✔
3% - 5%
0.29ms - 0.50ms
branch 377 kB 10.80ms - 10.95ms slower ❌
3% - 5%
0.29ms - 0.50ms
-

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 11.50ms - 12.21ms - unsure 🔍
-6% - +2%
-0.71ms - +0.23ms
branch 384 kB 11.80ms - 12.40ms unsure 🔍
-2% - +6%
-0.23ms - +0.71ms
-

icons permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 385 kB 31.00ms - 31.37ms - faster ✔
1% - 3%
0.43ms - 0.93ms
branch 363 kB 31.70ms - 32.04ms slower ❌
1% - 3%
0.43ms - 0.93ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 14.89ms - 15.12ms - faster ✔
8% - 11%
1.37ms - 1.89ms
branch 392 kB 16.40ms - 16.87ms slower ❌
9% - 13%
1.37ms - 1.89ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 215.50ms - 219.14ms - faster ✔
1% - 3%
1.26ms - 5.99ms
branch 470 kB 219.43ms - 222.45ms slower ❌
1% - 3%
1.26ms - 5.99ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 420 kB 48.94ms - 49.60ms - faster ✔
4% - 6%
2.00ms - 2.99ms
branch 396 kB 51.39ms - 52.14ms slower ❌
4% - 6%
2.00ms - 2.99ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 538 kB 70.39ms - 71.88ms - faster ✔
10% - 13%
7.53ms - 10.49ms
branch 515 kB 78.86ms - 81.43ms slower ❌
11% - 15%
7.53ms - 10.49ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 474.54ms - 484.28ms - unsure 🔍
-4% - +0%
-20.27ms - +1.75ms
branch 698 kB 478.79ms - 498.54ms unsure 🔍
-0% - +4%
-1.75ms - +20.27ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 822 kB 24.49ms - 25.79ms - faster ✔
5% - 10%
1.43ms - 2.84ms
branch 777 kB 27.00ms - 27.54ms slower ❌
5% - 11%
1.43ms - 2.84ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 812 kB 384.51ms - 389.82ms - faster ✔
2% - 4%
7.53ms - 15.29ms
branch 767 kB 395.74ms - 401.40ms slower ❌
2% - 4%
7.53ms - 15.29ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 609 kB 44.26ms - 45.56ms - faster ✔
6% - 9%
2.83ms - 4.58ms
branch 564 kB 48.04ms - 49.20ms slower ❌
6% - 10%
2.83ms - 4.58ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 428 kB 27.17ms - 27.69ms - faster ✔
5% - 8%
1.39ms - 2.28ms
branch 404 kB 28.90ms - 29.62ms slower ❌
5% - 8%
1.39ms - 2.28ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 568 kB 543.98ms - 551.83ms - faster ✔
1% - 3%
6.18ms - 19.11ms
branch 526 kB 555.42ms - 565.69ms slower ❌
1% - 3%
6.18ms - 19.11ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 12.02ms - 13.01ms - unsure 🔍
-6% - +3%
-0.76ms - +0.39ms
branch 373 kB 12.41ms - 12.99ms unsure 🔍
-3% - +6%
-0.39ms - +0.76ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 29.80ms - 30.63ms - faster ✔
1% - 5%
0.32ms - 1.49ms
branch 397 kB 30.71ms - 31.53ms slower ❌
1% - 5%
0.32ms - 1.49ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 420 kB 37.62ms - 38.44ms - faster ✔
2% - 6%
0.87ms - 2.23ms
branch 397 kB 39.03ms - 40.12ms slower ❌
2% - 6%
0.87ms - 2.23ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 486 kB 41.29ms - 44.42ms - unsure 🔍
-8% - +0%
-3.46ms - +0.14ms
branch 462 kB 43.63ms - 45.41ms unsure 🔍
-0% - +8%
-0.14ms - +3.46ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 81.93ms - 84.29ms - faster ✔
3% - 6%
2.56ms - 5.40ms
branch 470 kB 86.30ms - 87.88ms slower ❌
3% - 7%
2.56ms - 5.40ms
-

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 780 kB 1871.69ms - 1874.54ms - unsure 🔍
-0% - +0%
-2.09ms - +2.39ms
branch 736 kB 1871.24ms - 1874.69ms unsure 🔍
-0% - +0%
-2.39ms - +2.09ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 13.88ms - 14.24ms - faster ✔
8% - 11%
1.17ms - 1.72ms
branch 398 kB 15.29ms - 15.71ms slower ❌
8% - 12%
1.17ms - 1.72ms
-

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 15.56ms - 15.94ms - faster ✔
5% - 10%
0.79ms - 1.65ms
branch 390 kB 16.58ms - 17.36ms slower ❌
5% - 11%
0.79ms - 1.65ms
-

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 545 kB 131.69ms - 134.42ms - faster ✔
1% - 4%
0.97ms - 5.19ms
branch 496 kB 134.53ms - 137.74ms slower ❌
1% - 4%
0.97ms - 5.19ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 440 kB 122.33ms - 124.64ms - unsure 🔍
-3% - +0%
-3.25ms - +0.18ms
branch 416 kB 123.76ms - 126.28ms unsure 🔍
-0% - +3%
-0.18ms - +3.25ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 464 kB 13.13ms - 13.80ms - unsure 🔍
-1% - +5%
-0.07ms - +0.64ms
branch 441 kB 13.06ms - 13.31ms unsure 🔍
-5% - +0%
-0.64ms - +0.07ms
-

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 446 kB 25.33ms - 26.20ms - faster ✔
8% - 13%
2.26ms - 3.79ms
branch 423 kB 28.17ms - 29.42ms slower ❌
9% - 15%
2.26ms - 3.79ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 444 kB 28.55ms - 29.24ms - faster ✔
4% - 9%
1.17ms - 2.66ms
branch 421 kB 30.15ms - 31.47ms slower ❌
4% - 9%
1.17ms - 2.66ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 622 kB 36.31ms - 37.18ms - faster ✔
2% - 5%
0.58ms - 1.83ms
branch 576 kB 37.51ms - 38.40ms slower ❌
2% - 5%
0.58ms - 1.83ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 579 kB 25.02ms - 25.56ms - faster ✔
7% - 10%
1.85ms - 2.75ms
branch 537 kB 27.22ms - 27.96ms slower ❌
7% - 11%
1.85ms - 2.75ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 704 kB 55.28ms - 56.56ms - faster ✔
6% - 9%
3.40ms - 5.28ms
branch 659 kB 59.57ms - 60.95ms slower ❌
6% - 10%
3.40ms - 5.28ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 680 kB 43.95ms - 44.92ms - faster ✔
9% - 11%
4.15ms - 5.59ms
branch 635 kB 48.78ms - 49.84ms slower ❌
9% - 13%
4.15ms - 5.59ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 446 kB 41.70ms - 42.65ms - faster ✔
2% - 5%
0.86ms - 2.32ms
branch 422 kB 43.21ms - 44.32ms slower ❌
2% - 6%
0.86ms - 2.32ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 545 kB 63.72ms - 64.98ms - faster ✔
2% - 6%
1.29ms - 4.02ms
branch 519 kB 65.79ms - 68.21ms slower ❌
2% - 6%
1.29ms - 4.02ms
-
Firefox

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 176.04ms - 182.96ms - faster ✔
3% - 8%
6.46ms - 15.66ms
branch 407 kB 187.53ms - 193.59ms slower ❌
4% - 9%
6.46ms - 15.66ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 500 kB 113.94ms - 119.74ms - unsure 🔍
-6% - +0%
-7.24ms - +0.36ms
branch 476 kB 117.83ms - 122.73ms unsure 🔍
-0% - +6%
-0.36ms - +7.24ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 561 kB 155.30ms - 160.54ms - faster ✔
2% - 7%
3.60ms - 11.60ms
branch 518 kB 162.50ms - 168.54ms slower ❌
2% - 7%
3.60ms - 11.60ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 583 kB 114.15ms - 119.53ms - faster ✔
1% - 8%
1.74ms - 9.58ms
branch 541 kB 119.65ms - 125.35ms slower ❌
1% - 8%
1.74ms - 9.58ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 701 kB 280.78ms - 284.98ms - faster ✔
11% - 13%
34.25ms - 40.75ms
branch 659 kB 317.90ms - 322.86ms slower ❌
12% - 14%
34.25ms - 40.75ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 658 kB 138.44ms - 141.32ms - unsure 🔍
-0% - +2%
-0.17ms - +3.33ms
branch 616 kB 137.31ms - 139.29ms unsure 🔍
-2% - +0%
-3.33ms - +0.17ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 132.20ms - 136.96ms - unsure 🔍
-4% - +0%
-4.86ms - +0.58ms
branch 615 kB 135.40ms - 138.04ms unsure 🔍
-0% - +4%
-0.58ms - +4.86ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 847 kB 1887.52ms - 1894.84ms - unsure 🔍
-0% - +0%
-4.69ms - +4.49ms
branch 802 kB 1888.52ms - 1894.04ms unsure 🔍
-0% - +0%
-4.49ms - +4.69ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 845 kB 1895.09ms - 1900.03ms - unsure 🔍
-0% - +0%
-5.77ms - +1.97ms
branch 801 kB 1896.47ms - 1902.45ms unsure 🔍
-0% - +0%
-1.97ms - +5.77ms
-

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 438 kB 28.62ms - 31.06ms - unsure 🔍
-8% - +4%
-2.42ms - +1.18ms
branch 415 kB 29.13ms - 31.79ms unsure 🔍
-4% - +8%
-1.18ms - +2.42ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 497 kB 199.28ms - 206.76ms - unsure 🔍
-4% - +1%
-7.59ms - +2.75ms
branch 455 kB 201.88ms - 209.00ms unsure 🔍
-1% - +4%
-2.75ms - +7.59ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 718 kB 783.59ms - 795.89ms - faster ✔
2% - 5%
13.81ms - 39.11ms
branch 676 kB 805.14ms - 827.26ms slower ❌
2% - 5%
13.81ms - 39.11ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 489 kB 99.80ms - 106.36ms - faster ✔
2% - 10%
1.78ms - 10.58ms
branch 446 kB 106.33ms - 112.19ms slower ❌
2% - 10%
1.78ms - 10.58ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 495 kB 107.49ms - 112.59ms - faster ✔
3% - 10%
3.44ms - 11.68ms
branch 452 kB 114.36ms - 120.84ms slower ❌
3% - 11%
3.44ms - 11.68ms
-

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 516 kB 70.77ms - 75.15ms - faster ✔
1% - 8%
0.64ms - 6.44ms
branch 492 kB 74.60ms - 78.40ms slower ❌
1% - 9%
0.64ms - 6.44ms
-

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 429 kB 91.67ms - 97.69ms - unsure 🔍
-4% - +5%
-3.34ms - +4.34ms
branch 405 kB 91.80ms - 96.56ms unsure 🔍
-5% - +4%
-4.34ms - +3.34ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 678 kB 189.40ms - 192.08ms - faster ✔
3% - 5%
6.49ms - 10.35ms
branch 633 kB 197.77ms - 200.55ms slower ❌
3% - 5%
6.49ms - 10.35ms
-

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 509 kB 77.42ms - 79.78ms - faster ✔
1% - 5%
0.85ms - 3.99ms
branch 486 kB 79.99ms - 82.05ms slower ❌
1% - 5%
0.85ms - 3.99ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 61.43ms - 64.73ms - unsure 🔍
-4% - +2%
-2.57ms - +1.21ms
branch 718 kB 62.83ms - 64.69ms unsure 🔍
-2% - +4%
-1.21ms - +2.57ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 730.13ms - 745.27ms - slower ❌
0% - 4%
2.66ms - 28.94ms
branch 718 kB 711.15ms - 732.65ms faster ✔
0% - 4%
2.66ms - 28.94ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 109.08ms - 114.64ms - faster ✔
1% - 7%
1.28ms - 8.60ms
branch 644 kB 114.43ms - 119.17ms slower ❌
1% - 8%
1.28ms - 8.60ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 554 kB 118.36ms - 124.60ms - unsure 🔍
-5% - +1%
-6.75ms - +1.11ms
branch 511 kB 121.91ms - 126.69ms unsure 🔍
-1% - +6%
-1.11ms - +6.75ms
-

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 435 kB 104.43ms - 109.93ms - unsure 🔍
-5% - +2%
-5.59ms - +2.07ms
branch 411 kB 106.27ms - 111.61ms unsure 🔍
-2% - +5%
-2.07ms - +5.59ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 404 kB 52.88ms - 56.72ms - unsure 🔍
-4% - +6%
-2.01ms - +3.33ms
branch 381 kB 52.29ms - 55.99ms unsure 🔍
-6% - +4%
-3.33ms - +2.01ms
-

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 400 kB 20.21ms - 21.39ms - unsure 🔍
-6% - +1%
-1.21ms - +0.21ms
branch 377 kB 20.90ms - 21.70ms unsure 🔍
-1% - +6%
-0.21ms - +1.21ms
-

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 25.33ms - 26.87ms - unsure 🔍
-3% - +4%
-0.87ms - +1.15ms
branch 384 kB 25.31ms - 26.61ms unsure 🔍
-4% - +3%
-1.15ms - +0.87ms
-

icons permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 385 kB 51.35ms - 53.13ms - unsure 🔍
-3% - +2%
-1.44ms - +0.92ms
branch 363 kB 51.72ms - 53.28ms unsure 🔍
-2% - +3%
-0.92ms - +1.44ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 33.56ms - 35.24ms - faster ✔
2% - 9%
0.85ms - 3.39ms
branch 392 kB 35.57ms - 37.47ms slower ❌
2% - 10%
0.85ms - 3.39ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 431.04ms - 443.68ms - faster ✔
0% - 4%
0.24ms - 17.48ms
branch 470 kB 440.36ms - 452.08ms slower ❌
0% - 4%
0.24ms - 17.48ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 420 kB 81.83ms - 85.69ms - unsure 🔍
-6% - +1%
-5.49ms - +0.53ms
branch 396 kB 83.93ms - 88.55ms unsure 🔍
-1% - +7%
-0.53ms - +5.49ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 538 kB 145.14ms - 152.86ms - faster ✔
6% - 13%
10.42ms - 21.26ms
branch 515 kB 161.04ms - 168.64ms slower ❌
7% - 14%
10.42ms - 21.26ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 819 kB 656.76ms - 674.80ms - slower ❌
2% - 6%
16.05ms - 36.51ms
branch 774 kB 634.68ms - 644.32ms faster ✔
2% - 5%
16.05ms - 36.51ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 822 kB 48.52ms - 49.24ms - faster ✔
5% - 7%
2.40ms - 3.88ms
branch 777 kB 51.38ms - 52.66ms slower ❌
5% - 8%
2.40ms - 3.88ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 812 kB 670.63ms - 680.93ms - slower ❌
3% - 5%
16.69ms - 30.83ms
branch 767 kB 647.17ms - 656.87ms faster ✔
2% - 5%
16.69ms - 30.83ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 609 kB 91.30ms - 97.10ms - faster ✔
1% - 7%
0.56ms - 7.20ms
branch 564 kB 96.46ms - 99.70ms slower ❌
0% - 8%
0.56ms - 7.20ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 428 kB 57.21ms - 61.87ms - unsure 🔍
-7% - +4%
-4.08ms - +2.20ms
branch 404 kB 58.37ms - 62.59ms unsure 🔍
-4% - +7%
-2.20ms - +4.08ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 568 kB 1035.42ms - 1052.14ms - faster ✔
4% - 6%
45.19ms - 70.09ms
branch 526 kB 1092.19ms - 1110.65ms slower ❌
4% - 7%
45.19ms - 70.09ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 29.59ms - 32.49ms - unsure 🔍
-7% - +5%
-2.06ms - +1.66ms
branch 373 kB 30.08ms - 32.40ms unsure 🔍
-5% - +7%
-1.66ms - +2.06ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 58.66ms - 62.18ms - unsure 🔍
-3% - +3%
-2.09ms - +2.09ms
branch 397 kB 59.29ms - 61.55ms unsure 🔍
-3% - +3%
-2.09ms - +2.09ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 420 kB 73.42ms - 76.98ms - unsure 🔍
-8% - +0%
-5.96ms - +0.40ms
branch 397 kB 75.34ms - 80.62ms unsure 🔍
-1% - +8%
-0.40ms - +5.96ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 486 kB 70.32ms - 73.80ms - faster ✔
3% - 10%
2.51ms - 7.73ms
branch 462 kB 75.24ms - 79.12ms slower ❌
3% - 11%
2.51ms - 7.73ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 162.44ms - 169.76ms - faster ✔
1% - 6%
0.87ms - 10.45ms
branch 470 kB 168.67ms - 174.85ms slower ❌
0% - 6%
0.87ms - 10.45ms
-

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 780 kB 1873.45ms - 1877.79ms - unsure 🔍
-0% - -0%
-9.28ms - -3.00ms
branch 736 kB 1879.50ms - 1884.02ms unsure 🔍
+0% - +0%
+3.00ms - +9.28ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 33.26ms - 35.58ms - faster ✔
1% - 10%
0.35ms - 3.81ms
branch 398 kB 35.21ms - 37.79ms slower ❌
1% - 11%
0.35ms - 3.81ms
-

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 33.93ms - 36.55ms - unsure 🔍
-10% - -0%
-3.90ms - +0.06ms
branch 390 kB 35.68ms - 38.64ms unsure 🔍
-0% - +11%
-0.06ms - +3.90ms
-

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 545 kB 272.63ms - 281.97ms - faster ✔
0% - 4%
0.53ms - 12.55ms
branch 496 kB 280.06ms - 287.62ms slower ❌
0% - 5%
0.53ms - 12.55ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 440 kB 198.22ms - 206.06ms - unsure 🔍
-4% - +2%
-8.30ms - +3.30ms
branch 416 kB 200.36ms - 208.92ms unsure 🔍
-2% - +4%
-3.30ms - +8.30ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 464 kB 29.03ms - 31.45ms - unsure 🔍
-5% - +6%
-1.36ms - +1.72ms
branch 441 kB 29.11ms - 31.01ms unsure 🔍
-6% - +4%
-1.72ms - +1.36ms
-

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 446 kB 47.27ms - 49.49ms - faster ✔
5% - 12%
2.46ms - 6.54ms
branch 423 kB 51.18ms - 54.58ms slower ❌
5% - 14%
2.46ms - 6.54ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 444 kB 61.83ms - 65.97ms - unsure 🔍
-8% - +0%
-5.17ms - +0.37ms
branch 421 kB 64.45ms - 68.15ms unsure 🔍
-1% - +8%
-0.37ms - +5.17ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 704 kB 77.90ms - 81.10ms - slower ❌
4% - 9%
2.89ms - 6.95ms
branch 659 kB 73.33ms - 75.83ms faster ✔
4% - 9%
2.89ms - 6.95ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 579 kB 47.01ms - 49.39ms - faster ✔
2% - 8%
0.77ms - 3.99ms
branch 537 kB 49.49ms - 51.67ms slower ❌
1% - 8%
0.77ms - 3.99ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 704 kB 128.48ms - 135.48ms - slower ❌
3% - 10%
3.76ms - 12.16ms
branch 659 kB 121.70ms - 126.34ms faster ✔
3% - 9%
3.76ms - 12.16ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 680 kB 90.44ms - 93.80ms - faster ✔
8% - 13%
7.64ms - 13.28ms
branch 635 kB 100.31ms - 104.85ms slower ❌
8% - 15%
7.64ms - 13.28ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 446 kB 87.86ms - 93.58ms - faster ✔
2% - 11%
1.77ms - 10.63ms
branch 422 kB 93.54ms - 100.30ms slower ❌
2% - 12%
1.77ms - 10.63ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 545 kB 105.19ms - 110.53ms - unsure 🔍
-6% - +1%
-6.48ms - +0.80ms
branch 519 kB 108.22ms - 113.18ms unsure 🔍
-1% - +6%
-0.80ms - +6.48ms
-

Copy link
Contributor

@Rajdeepc Rajdeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! This will definitely help improve the documentation guidelines for our library. Though I see issues with the css on the tabs. It would be great if you could take a look at those before we do an official review!

@nikkimk
Copy link
Contributor Author

nikkimk commented Oct 2, 2024

Though I see issues with the css on the tabs. It would be great if you could take a look at those before we do an official review!

@Rajdeepc Can you be more specific about the issues with tabs please? Do you mean the Overview /API / Changelog tabs, the Tabs component documentation, or something else? Thanks!

@Rajdeepc
Copy link
Contributor

Rajdeepc commented Oct 8, 2024

  • Documentation Site
    Please review the changes. The Docs site is distorted. Check H1 and H2!
Screenshot 2024-10-08 at 10 16 39 AM

@nikkimk
Copy link
Contributor Author

nikkimk commented Oct 11, 2024

@Rajdeepc visual changes and heading hierarchy changes were intentional for accessibility. The heading markup reflects the content hierarchy now. Heading font sizes for all headings have increase so that subheadings are also accessible.

@nikkimk nikkimk requested a review from Rajdeepc October 11, 2024 14:38
@Rajdeepc
Copy link
Contributor

@Rajdeepc visual changes and heading hierarchy changes were intentional for accessibility. The heading markup reflects the content hierarchy now. Heading font sizes for all headings have increase so that subheadings are also accessible.

Agreed. Can you also run this through with the design team for a quick round of UI check?

Copy link
Collaborator

@najikahalsema najikahalsema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few things.

packages/action-button/README.md Outdated Show resolved Hide resolved
packages/action-button/README.md Outdated Show resolved Hide resolved
packages/action-menu/README.md Outdated Show resolved Hide resolved
packages/button/README.md Outdated Show resolved Hide resolved
packages/button/README.md Outdated Show resolved Hide resolved
packages/icon/README.md Outdated Show resolved Hide resolved
packages/icon/README.md Outdated Show resolved Hide resolved
packages/icon/README.md Outdated Show resolved Hide resolved
packages/icons-ui/README.md Outdated Show resolved Hide resolved
packages/icons/README.md Outdated Show resolved Hide resolved
nikkimk and others added 10 commits October 18, 2024 12:20
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
nikkimk and others added 16 commits October 18, 2024 17:50
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
@nikkimk
Copy link
Contributor Author

nikkimk commented Oct 22, 2024

@Rajdeepc got the following design recommendations and implemented them:

  • h1: heading XXL, serif, heavy
  • h2: heading L, sans-serif
  • h3: heading M, sans-serif
  • h4: heading S, sans-serif
  • h5: detail L
  • body: body M, sans-serif

Please take another look, keeping in mind that the scope of review should be limited to the heading changes and the documentation listed above.

Note: This PR (originally for sprint SWC05) will get merged into the #4756 where all the docs will be getting a final review.

Copy link
Collaborator

@najikahalsema najikahalsema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thank you!!!

@nikkimk
Copy link
Contributor Author

nikkimk commented Oct 24, 2024

Moved changes to #4756

@nikkimk nikkimk closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants