-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE]: accessibility docs for SWC05 #4757
Conversation
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Pull Request Test Coverage Report for Build 11462493768Details
💛 - Coveralls |
Tachometer resultsChromeaccordion permalinkbasic-test
action-bar permalinkbasic-test
action-button permalinkbasic-test
action-group permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
alert-banner permalinkbasic-test
alert-dialog permalinkbasic-test
breadcrumbs permalinkbasic-test
button-group permalinkbasic-test
button permalinktest-basic
card permalinktest-basic
checkbox permalinktest-basic
coachmark permalinkbasic-test
color-field permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
contextual-help permalinkbasic-test
dialog permalinkbasic-test
field-group permalinkbasic-test
field-label permalinkbasic-test
help-text permalinkbasic-test
icon permalinktest-basic
icons permalinktest-basic
infield-button permalinkbasic-test
menu permalinktest-basic
meter permalinkbasic-test
number-field permalinkbasic-test
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker-button permalinkbasic-test
picker permalinkbasic-test
popover permalinktest-basic
progress-bar permalinkbasic-test
radio permalinktest-basic
search permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
swatch permalinkbasic-test
switch permalinktest-basic
table permalinkbasic-test
tabs permalinkbasic-test
tags permalinkbasic-test
textfield permalinktest-basic
toast permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
top-nav permalinkbasic-test
truncated permalinkbasic-test
Firefoxaccordion permalinkbasic-test
action-bar permalinkbasic-test
action-button permalinkbasic-test
action-group permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
alert-banner permalinkbasic-test
alert-dialog permalinkbasic-test
breadcrumbs permalinkbasic-test
button-group permalinkbasic-test
button permalinktest-basic
card permalinktest-basic
checkbox permalinktest-basic
coachmark permalinkbasic-test
color-field permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
contextual-help permalinkbasic-test
dialog permalinkbasic-test
field-group permalinkbasic-test
field-label permalinkbasic-test
help-text permalinkbasic-test
icon permalinktest-basic
icons permalinktest-basic
infield-button permalinkbasic-test
menu permalinktest-basic
meter permalinkbasic-test
number-field permalinkbasic-test
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker-button permalinkbasic-test
picker permalinkbasic-test
popover permalinktest-basic
progress-bar permalinkbasic-test
radio permalinktest-basic
search permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
swatch permalinkbasic-test
switch permalinktest-basic
table permalinkbasic-test
tabs permalinkbasic-test
tags permalinkbasic-test
textfield permalinktest-basic
toast permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
top-nav permalinkbasic-test
truncated permalinkbasic-test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! This will definitely help improve the documentation guidelines for our library. Though I see issues with the css on the tabs. It would be great if you could take a look at those before we do an official review!
@Rajdeepc Can you be more specific about the issues with tabs please? Do you mean the Overview /API / Changelog tabs, the Tabs component documentation, or something else? Thanks! |
@Rajdeepc visual changes and heading hierarchy changes were intentional for accessibility. The heading markup reflects the content hierarchy now. Heading font sizes for all headings have increase so that subheadings are also accessible. |
Agreed. Can you also run this through with the design team for a quick round of UI check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few things.
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
Co-authored-by: Najika Halsema Yoo <[email protected]>
@Rajdeepc got the following design recommendations and implemented them:
Please take another look, keeping in mind that the scope of review should be limited to the heading changes and the documentation listed above. Note: This PR (originally for sprint SWC05) will get merged into the #4756 where all the docs will be getting a final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Thank you!!!
Moved changes to #4756 |
!!! NOTE TO REVIEWERS !!!
Please only review the docs listed in How has this been tested? section.
When this PR is reviewed, it will be merged into #4756, where all of the changes will be reviewed before merging into main.
Please place any other feedback in #4756
Description
Improving the accessibility documentation of components.
Related issue(s)
Motivation and context
Documentation should provide more information and examples that demonstrate how to use the components accessibly.
How has this been tested?
<sp-icon>
Review icon docs
<sp-icons>
Review icons docs
<sp-iconset>
Review iconset docs
<sp-icons-ui>
Review icons-ui docs
<sp-icons-workflow>
Review icons-workflow docs
Developing a Component Guide
1. You can use the WAVE browser extension's Structure tab to review heading structure.
Font sizes
h1
: heading XXL, serif, heavyh2
: heading L, sans-serifh3
: heading M, sans-serifh4
: heading S, sans-serifh5
: detail Lbody
: body M, sans-serifTypes of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.